View Change

2 comments:

• File src/soc/qualcomm/qcs405/blsp.c:

  • Patch Set #5, Line 45: clock_configure_i2c(19200000);

    I'd rather remove that value altogether, given how this function can only configure that one block.

    I understand this wrt the fix use case of one i2c instance.
    Are you confirming that there won't be any further change wrt usecase ?
    In that case we can remove this block and let us know where that change will happen ? Clock driver ?

  • Patch Set #5, Line 56: 1

    That seems to make more sense to me, yes. […]

    Ok we will add the check for id at the beginning of the API.
    "id" is needed for porting of this driver to future chips where number of i2c use cases can be more than one.

To view, visit change 32546. To unsubscribe, or for help writing mail filters, visit settings.