Thanks!
4 comments:
Patch Set #3, Line 9: Implement setting processor information to BMC.
If this IPMI OEM command is defined in a public doc (such as OCP doc), please include the link.
File src/drivers/ocp/ipmi/ipmi_ocp.h:
Patch Set #3, Line 7: #include <cpu/x86/msr.h>
Please only keep header files needed for this header file.
File src/drivers/ocp/ipmi/ipmi_ocp.c:
Patch Set #3, Line 65: memcpy(&req1.data.manufacturer_id, &mfid, 3);
what if CONFIG_MANU_ID is not defined?
Patch Set #3, Line 125: /* TBD */
What does the spec say about this? Why TBD? Should we just put stepping_id in req2.revision[0]?
To view, visit change 42242. To unsubscribe, or for help writing mail filters, visit settings.