Attention is currently required from: Tim Crawford, Cliff Huang, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60183 )
Change subject: soc/intel/common/block/pcie/rtd3: Update ACPI methods for CPU PCIe RPs
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/60183/comment/31dd4a5c_7ba24f0c
PS4, Line 284: printk(BIOS_ERR, "%s: Unknown PCIe RP\n", __func__);
do we need to maintain this msg in https://review.coreboot.org/c/coreboot/+/60183/4..5/src/soc/intel/common/blo... ?
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/60183/comment/f96a329c_df136140
PS5, Line 293: CPU
nit: `get_pcie_rp_pmc_idx()` function can return -1 irrespective of being PCH or CPU hence just *CPU* in debug log might be misleading? Can we go for more generic word, may be PCIe(CPU/PCH)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60183
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84a1affb32cb53e686dbe825d3c3a424715df873
Gerrit-Change-Number: 60183
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 06 Jan 2022 10:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment