Felix Held submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
soc/amd: use apm_get_apmc() in APMC SMI handler

Instead of open-coding this functionality, call the apm_get_apmc()
helper function.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iac6b614d900e51d91a0c155116a5edc29775ea99
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79836
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
---
M src/soc/amd/common/block/cpu/smm/smi_apmc.c
M src/soc/amd/stoneyridge/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/amd/common/block/cpu/smm/smi_apmc.c b/src/soc/amd/common/block/cpu/smm/smi_apmc.c
index 0eab86c..9df6ae3 100644
--- a/src/soc/amd/common/block/cpu/smm/smi_apmc.c
+++ b/src/soc/amd/common/block/cpu/smm/smi_apmc.c
@@ -91,7 +91,7 @@

void fch_apmc_smi_handler(void)
{
- const uint8_t cmd = inb(pm_acpi_smi_cmd_port());
+ const uint8_t cmd = apm_get_apmc();

switch (cmd) {
case APM_CNT_ACPI_ENABLE:
diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c
index a8521c5..f962fa0 100644
--- a/src/soc/amd/stoneyridge/smihandler.c
+++ b/src/soc/amd/stoneyridge/smihandler.c
@@ -21,7 +21,7 @@
*/
static void stoneyridge_fch_apmc_smi_handler(void)
{
- const uint8_t cmd = inb(pm_acpi_smi_cmd_port());
+ const uint8_t cmd = apm_get_apmc();

switch (cmd) {
case APM_CNT_ACPI_ENABLE:

To view, visit change 79836. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac6b614d900e51d91a0c155116a5edc29775ea99
Gerrit-Change-Number: 79836
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged