6 comments:
Patch Set #3, Line 7: soc/intel/tigerlake: Update fsp params for Jasper Lake.
Please remove the dot/period at the end.
Done
Patch Set #3, Line 10: Graphics
graphics
Done
Update fsp parameters for Jasper Lake SoC.
Update fsp parameters for various configuration like Graphics, USB, xDCI,
PCI root ports etc.
Please format this as a list/enumeration.
Done
File src/soc/intel/tigerlake/fsp_params_jsl.c:
/* Set USB OC pin to 0 first */
for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++)
params->Usb2OverCurrentPin[i] = 0;
for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++)
params->Usb3OverCurrentPin[i] = 0;
not needed?
Done
/* Override/Fill Fsp Silicon Param for mainboard */
mainboard_silicon_init_params(params);
can we move this to end after local assignments
Done
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
Patch Set #3, Line 99: soc_memory_init_params(m_cfg, config);
move at end after local assignments?
Done
To view, visit change 38461. To unsubscribe, or for help writing mail filters, visit settings.