Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Richard Spiegel: Looks good to me, but someone else must approve
src/arch/x86/acpi.c: Update ACPI table's revision numbers

Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/29579
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-by: Martin Roth <martinroth@google.com>
---
M src/arch/x86/acpi.c
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 1872276..623a6df 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1394,7 +1394,7 @@
switch (table) {
case FADT:
return ACPI_FADT_REV_ACPI_3_0;
- case MADT: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */
+ case MADT: /* ACPI 3.0: 2, ACPI 4.0/5.0: 3, ACPI 6.2b/6.3: 5 */
return 2;
case MCFG:
return 1;
@@ -1402,29 +1402,29 @@
return 2;
case TPM2:
return 4;
- case SSDT: /* ACPI 1.0/2.0: ?, ACPI 3.0/4.0: 2 */
+ case SSDT: /* ACPI 3.0 upto 6.3: 2 */
return 2;
- case SRAT: /* ACPI 1.0: N/A, 2.0: 1, 3.0: 2, 4.0: 3 */
+ case SRAT: /* ACPI 2.0: 1, ACPI 3.0: 2, ACPI 4.0 upto 6.3: 3 */
return 1; /* TODO Should probably be upgraded to 2 */
case DMAR:
return 1;
- case SLIT: /* ACPI 1.0: N/A, ACPI 2.0/3.0/4.0: 1 */
+ case SLIT: /* ACPI 2.0 upto 6.3: 1 */
return 1;
case HPET: /* Currently 1. Table added in ACPI 2.0. */
return 1;
- case VFCT: /* ACPI 1.0: N/A, ACPI 2.0/3.0/4.0: 1 */
+ case VFCT: /* ACPI 2.0/3.0/4.0: 1 */
return 1;
case IVRS:
return IVRS_FORMAT_FIXED;
case DBG2:
return 0;
- case FACS: /* ACPI 1.0: 0, ACPI 2.0/3.0: 1, ACPI 4.0: 2 */
+ case FACS: /* ACPI 2.0/3.0: 1, ACPI 4.0 upto 6.3: 2 */
return 1;
- case RSDT: /* ACPI 1.0/2.0/3.0/4.0: 1 */
+ case RSDT: /* ACPI 1.0 upto 6.3: 1 */
return 1;
- case XSDT: /* ACPI 1.0: N/A, 2.0/3.0/4.0: 1 */
+ case XSDT: /* ACPI 2.0 upto 6.3: 1 */
return 1;
- case RSDP: /* ACPI 1.0: 0, ACPI 2.0/3.0/4.0: 2. */
+ case RSDP: /* ACPI 2.0 upto 6.3: 2 */
return 2;
case HEST:
return 1;

To view, visit change 29579. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb
Gerrit-Change-Number: 29579
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged