[coreboot-gerrit] Change in coreboot[master]: soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44060 )

Change subject: soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming
......................................................................


Patch Set 1:
> Patch Set 1:
> > Patch Set 1:
> >
> > So if I understand correctly, right now SMRAM on these platforms remains unlocked after coreboot loads the payload?
>
> This are compatible SMRAM region locking not the actual DRAM based SMRAM locking stuff. This register controls below 1 MB VGA region (0xA_0000 till 0xB_FFFF)
>
> Here is the register range that this register protects:
>
> C_BASE_SEG: This field indicates the location of SMM space. Only SMM space between A_0000h and
> B_FFFFh is supported, so this field is hardwired to 010b

Ah right, this only locks the CSEG, which we don't typically use here in coreboot, preferring TSEG instead. To "lock" access to TSEG, we program the SMRR registers to prevent access to SMRAM (TSEG region) from any other SAI than SMM_SAI. Is my understanding correct?


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f581b90ea99012980f439a7914e8d901585b004
Gerrit-Change-Number: 44060
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Rizwan Qureshi <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: Wonkyu Kim <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Tim Wawrzynczak <[e-mail]>
Gerrit-Comment-Date: Fri, 31 Jul 2020 21:06:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment