View Change
1 comment:
Commit Message:
Patch Set #1, Line 11:
it's actually slower than simply letting FSP (vs coreboot)
read the SPD data via smbus, so drop it.
Shouldn't FSP-M have some logic to decide whether to do a full training?
Ideally yes. But, in practice, we observed that FSP-M does not do that. Hence, coreboot had to do it.
To view, visit change 47899. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e4db9ba9fdb0fa9fafb2645819b111d381b5756
Gerrit-Change-Number: 47899
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen@intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Wed, 09 Dec 2020 18:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Chen <jamie.chen@intel.corp-partner.google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment