[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/genoa/reset.c: Add reset methods

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76503?usp=email )

(

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: soc/amd/genoa/reset.c: Add reset methods
......................................................................

soc/amd/genoa/reset.c: Add reset methods

Signed-off-by: Arthur Heymans 
Change-Id: Ifb4d7dda5fcf1ccacb901b24e4f7cf6945ee16e0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76503
Reviewed-by: Matt DeVillier 
Reviewed-by: Martin Roth 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/amd/onyx/Kconfig
M src/soc/amd/genoa/Makefile.inc
A src/soc/amd/genoa/reset.c
3 files changed, 28 insertions(+), 1 deletion(-)

Approvals:
  Matt DeVillier: Looks good to me, but someone else must approve
  Martin Roth: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/mainboard/amd/onyx/Kconfig b/src/mainboard/amd/onyx/Kconfig
index 260a498..21c8c85 100644
--- a/src/mainboard/amd/onyx/Kconfig
+++ b/src/mainboard/amd/onyx/Kconfig
@@ -3,7 +3,6 @@
 config BOARD_SPECIFIC_OPTIONS
    def_bool y
    select SOC_AMD_GENOA
-	select MISSING_BOARD_RESET
    select BOARD_ROMSIZE_KB_32768

config FMDFILE
diff --git a/src/soc/amd/genoa/Makefile.inc b/src/soc/amd/genoa/Makefile.inc
index 56a98e6..efbd3b1 100644
--- a/src/soc/amd/genoa/Makefile.inc
+++ b/src/soc/amd/genoa/Makefile.inc
@@ -2,6 +2,7 @@
 ifeq ($(CONFIG_SOC_AMD_GENOA),y)

all-y		+= mmap_boot.c
+all-y		+= reset.c
 all-y		+= config.c

bootblock-y	+= early_fch.c
diff --git a/src/soc/amd/genoa/reset.c b/src/soc/amd/genoa/reset.c
new file mode 100644
index 0000000..ac0c981
--- /dev/null
+++ b/src/soc/amd/genoa/reset.c
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <arch/io.h>
+#include <cf9_reset.h>
+#include <reset.h>
+#include <soc/southbridge.h>
+#include <amdblocks/acpimmio.h>
+#include <amdblocks/reset.h>
+
+void do_cold_reset(void)
+{
+	/* De-assert and then assert all PwrGood signals on CF9 reset. */
+	pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) |
+		TOGGLE_ALL_PWR_GOOD);
+	outb(RST_CPU | SYS_RST, RST_CNT);
+}
+
+void do_warm_reset(void)
+{
+	/* Warm resets are not supported and must be executed as cold */
+	do_cold_reset();
+}
+
+void do_board_reset(void)
+{
+	do_cold_reset();
+}