Matt DeVillier has uploaded this change for review.
google/lulu,gandof: set kb backlight on boot
Set keyboard backlight to 75% on boot, except when resuming
from S3. This enables the backlight at a reasonable level
prior to the OS driver taking over, providing early proof-of-life
and enhanced usability in grub etc.
Uses same method as other google boards with a keyboard backlight
(chell, link, samus). 75% value determined based on user feedback.
TEST: boot google/lulu,gandof boards, observe keyboard backlight
enabled in pre-OS environment.
Change-Id: I7ed59289419af21764b1b5bd0a534d3b630c6c6b
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
---
M src/mainboard/google/auron/variants/gandof/variant.c
M src/mainboard/google/auron/variants/lulu/variant.c
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/21330/1
diff --git a/src/mainboard/google/auron/variants/gandof/variant.c b/src/mainboard/google/auron/variants/gandof/variant.c
index f1af14d..ad88f0d 100644
--- a/src/mainboard/google/auron/variants/gandof/variant.c
+++ b/src/mainboard/google/auron/variants/gandof/variant.c
@@ -11,6 +11,8 @@
* GNU General Public License for more details.
*/
+#include <ec/google/chromeec/ec.h>
+#include <soc/pm.h>
#include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h>
@@ -35,5 +37,6 @@
void variant_romstage_entry(struct romstage_params *rp)
{
- /* N/A for boards other than SAMUS */
+ if (rp->power_state->prev_sleep_state != ACPI_S3)
+ google_chromeec_kbbacklight(75);
}
diff --git a/src/mainboard/google/auron/variants/lulu/variant.c b/src/mainboard/google/auron/variants/lulu/variant.c
index 740decf..9d77c27 100644
--- a/src/mainboard/google/auron/variants/lulu/variant.c
+++ b/src/mainboard/google/auron/variants/lulu/variant.c
@@ -11,6 +11,8 @@
* GNU General Public License for more details.
*/
+#include <ec/google/chromeec/ec.h>
+#include <soc/pm.h>
#include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h>
@@ -44,5 +46,6 @@
void variant_romstage_entry(struct romstage_params *rp)
{
- /* N/A for boards other than SAMUS */
+ if (rp->power_state->prev_sleep_state != ACPI_S3)
+ google_chromeec_kbbacklight(75);
}
To view, visit change 21330. To unsubscribe, visit settings.