Patch Set 11:
(1 comment)
It's very straight forward implementation.
3 comments:
File src/soc/intel/apollolake/cse.c:
Patch Set #11, Line 46: #define dump_status(index, hfs_reg) me_read_config32(hfs_reg)
you can remove dump_status from everywhere and just use me_read_config32.
Done
File src/soc/intel/common/block/cse/cse.c:
Patch Set #2, Line 518: index = 1
its not done.
There is no benefit/optimization going with static structure. Hence, prefer to keep "else if" ladder implementation.
File src/soc/intel/common/block/cse/cse.c:
if (offset == PCI_ME_HFSTS1)
index = 1;
else if (offset == PCI_ME_HFSTS2)
index = 2;
else if (offset == PCI_ME_HFSTS3)
index = 3;
else if (offset == PCI_ME_HFSTS4)
index = 4;
else if (offset == PCI_ME_HFSTS5)
index = 5;
else if (offset == PCI_ME_HFSTS6)
index = 6;
would using a static structure beautify it? like below.. […]
Done
To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.