Attention is currently required from: Subrata Banik, Reka Norman, Nick Vaccaro, Julius Werner, Angel Pons, Karthikeyan Ramasubramanian.

Patch set 2:Code-Review -2

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    The reason for using a stage cache in TSEG for the S3 resume path is for security reasons. After SMM is locked down, that memory cannot be modified by the OS. The SPI flash on the other hand can be modified if we are on a RW_A/B path.

    Also whether reading from cached SPI flash (with prefetch enabled) is faster than reading uncached DRAM is probably platform dependent.

    Also https://review.coreboot.org/c/coreboot/+/36674/22 does set up caching for the stage cache region (and cbmem). Maybe that will provide you some performance boosts?

To view, visit change 68641. To unsubscribe, or for help writing mail filters, visit settings.