Patch Set 1:

(1 comment)

A bit off-topic, but I think the development effort should be in providing good methods for equivalent of normal/fallback boot flows with and without VBOOT installed. Should we support configuration where bootblock has only CBMEM console enabled, while SPI/EHCI consoles would be delayed to (fallback) romstage? Assuming one does not completely mess up the build of an experimental romstage, bootblock and VBOOT debug output from CBMEM could be replayed to SPI/EHCI even before raminit? This would often bring bootblock size downto 16 KiB or less, while not having undesirable speed impact for 'stable or normal' boot flow.

Yes, please! That should only be a matter of changing the condition of the linker scripts.
On that same topic, would it not be a good idea for the bootblock to conditionally set a global parameter to output over slower consoles. For instance if the bootblock detects X amount of failures set that parameter that affects next stages.

View Change

To view, visit change 36418. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 18:34:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment