Attention is currently required from: Arthur Heymans, Christian Walter, Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Felix Held, Jeff Daly, Johnny Lin, Julius Werner, Kapil Porwal, Martin L Roth, Subrata Banik, Tarun, Tim Chu, Vanessa Eusebio.
View Change
1 comment:
Patchset:
Patch Set #1:
Are you arguing that we can't do byte-wise arithmetic with `void *`,
No. I only mentioned it because if we'd create a new type, it should support that.
or more generally that `void *` shouldn't point to something that's not allocated by the C runtime because of language minutiae in the standard?
That's what I had in mind when I wrote "technically ... 100% wrong". But
it's not related to my proposal. I'm not aware of any minutiae that could
bite us here.
I only proposed `mmio_addr` because people asked for type safety.
(I think the main concern about lack of type safety is that people confuse the order of the address and value arguments, especially since we used to have `writel(val, addr)` functions in the past that had it exactly the other way around, and some other firmware projects still do. Using `void *` at least solves that problem. I think accidentally using some other random pointer is not a common mistake.)
I haven't seen any order mistake for a long time. And writel() etc. are gone
for a while. Do you think it's still a problem?
To view, visit change 80193. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4022e3bbfacf35d0529e46dc82cf303dae9438e4
Gerrit-Change-Number: 80193
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Jeff Daly <jeffd@silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Martin L Roth <gaumless@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Jeff Daly <jeffd@silicom-usa.com>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Comment-Date: Thu, 08 Feb 2024 09:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Martin L Roth <gaumless@gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment