Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31382 ) Change subject: ec/quanta/it8518: Use ACPI EC code ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/31382/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/31382/3//COMMIT_MSG@15 PS3, Line 15: : Also fix a bad constant MBAT_STATUS. Why is it "bad"? Why is it done in this change? -- To view, visit https://review.coreboot.org/c/coreboot/+/31382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bea7445f34817cef1602843bbded59230bb8d47 Gerrit-Change-Number: 31382 Gerrit-PatchSet: 3 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 22 Nov 2019 15:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment