Patch Set 30:

Patch Set 30: Code-Review+2

Patch Set 29:

(2 comments)

Thanks!

Thanks to you as well! 😊

Just to make sure, was the last patchset tested on hardware? Would be good to check if the ACPI suggestions don't cause any problems.

Yes, it was tested on hardware. In addition, we plan to conduct a visual investigation of ACPI tables generated in target OS, also run ACPI related tests in target OS.

Sounds great, thanks for confirming!

View Change

To view, visit change 40387. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a5234d483e4ddea1cd37643b41f6aba65729c8e
Gerrit-Change-Number: 40387
Gerrit-PatchSet: 30
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 20 Jun 2020 11:02:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment