Patch Set 1:

I don't think you want to override the uart_init function here. You just want to change the CONFIG from 3f8 to a different port defined by VPD. That should be genric and not platform specific code.

Yes, that's my purpose, I modify the function as weak, so I could override it without adding kconfig for platform.

View Change

To view, visit change 45405. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
Gerrit-Change-Number: 45405
Gerrit-PatchSet: 2
Gerrit-Owner: Bryant Ou <bryant.ou.q@gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese@9elements.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung%quantatw.com@gtempaccount.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 16 Sep 2020 07:45:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment