13 comments:
File src/cpu/intel/speedstep/acpi.c:
Patch Set #13, Line 68: if ( c.x86_model ==2)
spaces required around that '==' (ctx:WxV)
Patch Set #13, Line 68: if ( c.x86_model ==2)
space prohibited after that open parenthesis '('
else is not generally useful after a break or return
File src/cpu/intel/speedstep/speedstep.c:
Patch Set #13, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and
line over 80 characters
Patch Set #13, Line 46: enabled bits */
line over 80 characters
Patch Set #13, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask);
line over 80 characters
code indent should use tabs where possible
please, no spaces at the start of a line
Patch Set #13, Line 73: if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) {
suspect code indent for conditional statements (8, 8)
Patch Set #13, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) {
line over 80 characters
Patch Set #13, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask);
line over 80 characters
code indent should use tabs where possible
please, no spaces at the start of a line
To view, visit change 22604. To unsubscribe, or for help writing mail filters, visit settings.