build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 )
Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ......................................................................
Patch Set 13:
(13 comments)
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@68 PS13, Line 68: if ( c.x86_model ==2) spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@68 PS13, Line 68: if ( c.x86_model ==2) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@92 PS13, Line 92: else else is not generally useful after a break or return
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c:
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and line over 80 characters
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 46: enabled bits */ line over 80 characters
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); line over 80 characters
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 52: } code indent should use tabs where possible
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 52: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 73: if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) { line over 80 characters
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask); line over 80 characters
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 82: } code indent should use tabs where possible
https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c... PS13, Line 82: } please, no spaces at the start of a line