[coreboot-gerrit] Change in coreboot[master]: src/lib: Add FW_CONIFG_SOURCE_VPD

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Julius Werner, Subrata Banik, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58839 )

Change subject: src/lib: Add FW_CONIFG_SOURCE_VPD
......................................................................


Patch Set 4:

(3 comments)

File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/58839/comment/0268b3d6_ed313eb3 
PS4, Line 421: depends on FW_CONFIG
`depends on FW_CONFIG && VPD`


File src/lib/fw_config.c:

https://review.coreboot.org/c/coreboot/+/58839/comment/d1a7df99_d456ebbc 
PS4, Line 51: int32_t
nit: `int`, then no casting is needed below?


https://review.coreboot.org/c/coreboot/+/58839/comment/97aafee9_f5c5047c 
PS4, Line 59: fw_config_value = UNDEFINED_FW_CONFIG;
this line is redundant



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4df7d5612e18957416a40ab854fa63c8b11b4216
Gerrit-Change-Number: 58839
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim <[e-mail]>
Gerrit-Reviewer: Jamie Ryu <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Raj Astekar <[e-mail]>
Gerrit-Reviewer: Ravishankar Sarawadi <[e-mail]>
Gerrit-Reviewer: Srinidhi N Kaushik <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Jamie Ryu <[e-mail]>
Gerrit-Attention: Wonkyu Kim <[e-mail]>
Gerrit-Attention: Ravishankar Sarawadi <[e-mail]>
Gerrit-Attention: Julius Werner <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Attention: Srinidhi N Kaushik <[e-mail]>
Gerrit-Attention: Raj Astekar <[e-mail]>
Gerrit-Comment-Date: Wed, 03 Nov 2021 14:26:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment