Patch set 2:Code-Review +1
12 comments:
Patch Set #2, Line 9: Xeon-SP a Skylake Scalable Processor can have 36 CPU threads(18 cores). Current
nit: Please wrap these lines at 72 characters
Could we please add a prompt here so that one can easily enable it?
File src/cpu/x86/smm/smm_module_loaderv2.c:
Patch Set #2, Line 15: uint8_t
#include <stdint.h>
Patch Set #2, Line 51: unsigned int
Are these memory addresses? If so, I'd use uintptr_t
Patch Set #2, Line 108: printk(BIOS_ERR, "%s: unable to get SMM module size\n", __func__);
Can we continue after this error?
Patch Set #2, Line 112: 0xFFFF
What does this magic number mean?
Shouldn't this be an uintptr_t as well?
Patch Set #2, Line 213: unsigned int
uintptr_t
Patch Set #2, Line 226: params->smm_main_entry_offset < stack_top) {
I'd indent this part differently so that it is clear it's a continuation (e.g. add a tab)
Patch Set #2, Line 231: __func__, cpus[num_cpus].smbase, stack_top);
one more tab
Patch Set #2, Line 604: "%s: need more SMRAM\n", __func__);
add another tab
File src/include/cpu/x86/smm.h:
Patch Set #2, Line 152: #if CONFIG(X86_SMM_LOADER_VERSION2)
nit: I would not indent preprocessor
To view, visit change 43684. To unsubscribe, or for help writing mail filters, visit settings.