Patch set 12:Code-Review +1
1 comment:
File src/soc/intel/apollolake/mmap_boot.c:
map = rdev_mmap(&real_dev.rdev, region_offset(&cbfs_region), region_sz(&cbfs_region));
if (map)
rdev_munmap(&real_dev.rdev, map);
if I understand this part right, wouldn't
```
if (!region_overlap(&real_dev.rdev, &cbfs_region))
printk(error);
```
work to avoid the unnecessary mmap op ? I guess mmap for x86 boot media is a noop for now so it's not a big deal.
To view, visit change 47658. To unsubscribe, or for help writing mail filters, visit settings.