Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik, sridhar siricilla.

Patch set 6:Code-Review +1

View Change

6 comments:

• Patchset:

  • Patch Set #6:

    Looks good. I have a few suggestions.

• File src/soc/intel/common/block/systemagent/systemagent.c:

  • Patch Set #6, Line 327: const struct device *dev

    You know which device the sa. Why not use that directly use _pci_0_00_0? Then you have compiletime checks vs runtime null check + your sure to use the right device.

    Some for all the ones below.

  • Patch Set #6, Line 340: BIOS_DEBUG

    Probably should be BIOS_ERR if CONFIG_ECAM_MMCONF_SUPPORT (that's always the case on modern HW)?

  • Patch Set #6, Line 346: 4 * ((uint64_t)GiB);

    '4ull * GiB' looks better IMO.

  • Patch Set #6, Line 367: BIOS_DEBUG

    BIOS_ERR

  • Patch Set #6, Line 432: sa_get_dpr_size

    txt_get_chipset_dpr() in systemagent_early.c does the same.

To view, visit change 80362. To unsubscribe, or for help writing mail filters, visit settings.