Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jonathan Zhang: Looks good to me, but someone else must approve
mb/ocp/deltalake: Update SMBIOS type 8 information

Update port connector information for Delta Lake.

Tested=Execute "dmidecode -t 8" to check all the information of
SMBIOS type 8 is correct.

Signed-off-by: Tim Chu <Tim.Chu@quantatw.com>
Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47893
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathan Zhang <jonzhang@fb.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 31 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 96b0060..72a74da 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -180,6 +180,30 @@
}
}

+static const struct port_information smbios_type8_info[] = {
+ {
+ .internal_reference_designator = "JCN18 - CPU MIPI60",
+ .internal_connector_type = CONN_OTHER,
+ .external_reference_designator = "",
+ .external_connector_type = CONN_NONE,
+ .port_type = TYPE_OTHER_PORT
+ },
+ {
+ .internal_reference_designator = "JCN32 - TPM_CONN",
+ .internal_connector_type = CONN_OTHER,
+ .external_reference_designator = "",
+ .external_connector_type = CONN_NONE,
+ .port_type = TYPE_OTHER_PORT
+ },
+ {
+ .internal_reference_designator = "JCN7 - USB type C",
+ .internal_connector_type = CONN_USB_TYPE_C,
+ .external_reference_designator = "",
+ .external_connector_type = CONN_NONE,
+ .port_type = TYPE_USB
+ },
+};
+
static int create_smbios_type9(int *handle, unsigned long *current)
{
int index;
@@ -281,6 +305,13 @@
{
int len = 0;

+ // add port information
+ len += smbios_write_type8(
+ current, handle,
+ smbios_type8_info,
+ ARRAY_SIZE(smbios_type8_info)
+ );
+
len += create_smbios_type9(handle, current);

return len;

To view, visit change 47893. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
Gerrit-Change-Number: 47893
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung%quantatw.com@gtempaccount.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged