64 comments:
File src/soc/qualcomm/qcs405/blsp.c:
Patch Set #3, Line 49: case BLSP_QUP_ID_1:
code indent should use tabs where possible
Patch Set #3, Line 49: case BLSP_QUP_ID_1:
please, no spaces at the start of a line
Patch Set #3, Line 54: break;
code indent should use tabs where possible
Patch Set #3, Line 54: break;
please, no spaces at the start of a line
Patch Set #3, Line 55: default:
code indent should use tabs where possible
Patch Set #3, Line 56: return 1;
code indent should use tabs where possible
Patch Set #3, Line 56: return 1;
please, no spaces at the start of a line
code indent should use tabs where possible
please, no spaces at the start of a line
File src/soc/qualcomm/qcs405/i2c.c:
Patch Set #3, Line 87: if (QUP_SUCCESS != qup_ret)
Comparisons should place the constant on the right side of the test
Patch Set #3, Line 106: if (QUP_SUCCESS != qup_ret)
Comparisons should place the constant on the right side of the test
Patch Set #3, Line 157: int platform_i2c_transfer(unsigned bus, struct i2c_msg *segments,
Prefer 'unsigned int' to bare use of 'unsigned'
File src/soc/qualcomm/qcs405/qup.c:
Patch Set #3, Line 59: u32 clk_freq_out;
code indent should use tabs where possible
Patch Set #3, Line 59: u32 clk_freq_out;
please, no spaces at the start of a line
Patch Set #3, Line 60: u8 fs_div;
code indent should use tabs where possible
Patch Set #3, Line 60: u8 fs_div;
please, no spaces at the start of a line
Patch Set #3, Line 61: u8 ht_div;
code indent should use tabs where possible
Patch Set #3, Line 61: u8 ht_div;
please, no spaces at the start of a line
Patch Set #3, Line 65: {100000, 124, 62},
code indent should use tabs where possible
Patch Set #3, Line 65: {100000, 124, 62},
please, no spaces at the start of a line
Patch Set #3, Line 66: {400000, 28, 14},
code indent should use tabs where possible
Patch Set #3, Line 66: {400000, 28, 14},
please, no spaces at the start of a line
Patch Set #3, Line 67: {1000000, 8, 5},
code indent should use tabs where possible
Patch Set #3, Line 67: {1000000, 8, 5},
please, no spaces at the start of a line
Patch Set #3, Line 70: static void i2c_set_mstr_clk_ctl(unsigned id, unsigned hz)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 70: static void i2c_set_mstr_clk_ctl(unsigned id, unsigned hz)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 72: int i;
code indent should use tabs where possible
Patch Set #3, Line 72: int i;
please, no spaces at the start of a line
Patch Set #3, Line 73: struct i2c_clk_div_fld *itr = i2c_clk_div_map;
code indent should use tabs where possible
Patch Set #3, Line 73: struct i2c_clk_div_fld *itr = i2c_clk_div_map;
please, no spaces at the start of a line
Patch Set #3, Line 74: u8 fs_div = 0;
code indent should use tabs where possible
Patch Set #3, Line 74: u8 fs_div = 0;
please, no spaces at the start of a line
Patch Set #3, Line 75: u8 ht_div = 0;
code indent should use tabs where possible
Patch Set #3, Line 75: u8 ht_div = 0;
please, no spaces at the start of a line
Patch Set #3, Line 76: u32 mstr_clk_ctl;
code indent should use tabs where possible
Patch Set #3, Line 76: u32 mstr_clk_ctl;
please, no spaces at the start of a line
Patch Set #3, Line 78: for (i = 0; i < ARRAY_SIZE(i2c_clk_div_map); ++i, ++itr) {
code indent should use tabs where possible
Patch Set #3, Line 78: for (i = 0; i < ARRAY_SIZE(i2c_clk_div_map); ++i, ++itr) {
please, no spaces at the start of a line
Patch Set #3, Line 79: if (hz == itr->clk_freq_out) {
code indent should use tabs where possible
Patch Set #3, Line 79: if (hz == itr->clk_freq_out) {
please, no spaces at the start of a line
Patch Set #3, Line 80: if (!fs_div)
code indent should use tabs where possible
Patch Set #3, Line 80: if (!fs_div)
please, no spaces at the start of a line
Patch Set #3, Line 81: fs_div = itr->fs_div;
code indent should use tabs where possible
Patch Set #3, Line 81: fs_div = itr->fs_div;
please, no spaces at the start of a line
Patch Set #3, Line 82: if (!ht_div)
code indent should use tabs where possible
Patch Set #3, Line 82: if (!ht_div)
please, no spaces at the start of a line
Patch Set #3, Line 83: ht_div = itr->ht_div;
code indent should use tabs where possible
Patch Set #3, Line 83: ht_div = itr->ht_div;
please, no spaces at the start of a line
Patch Set #3, Line 84: break;
code indent should use tabs where possible
Patch Set #3, Line 84: break;
please, no spaces at the start of a line
code indent should use tabs where possible
please, no spaces at the start of a line
code indent should use tabs where possible
please, no spaces at the start of a line
Patch Set #3, Line 88: /* format values in clk-ctl cache */
code indent should use tabs where possible
Patch Set #3, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff);
code indent should use tabs where possible
Patch Set #3, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff);
please, no spaces at the start of a line
Patch Set #3, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff);
need consistent spacing around '|' (ctx:WxV)
Patch Set #3, Line 141: static qup_return_t qup_wait_for_state(blsp_qup_id_t id, unsigned wait_for)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 236: unsigned data_len = p_tx_obj->p.iic.data_len;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 237: unsigned idx = 0;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 353: unsigned data_len = p_tx_obj->p.iic.data_len;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 354: unsigned idx = 0;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #3, Line 513: unsigned curr_state = read32(QUP_ADDR(id, QUP_STATE));
Prefer 'unsigned int' to bare use of 'unsigned'
To view, visit change 32546. To unsubscribe, or for help writing mail filters, visit settings.