Patch set 1:Code-Review +1

View Change

4 comments:

• File src/soc/intel/xeon_sp/memmap.c:

  • Patch Set #1, Line 5: pci

    pci_ops ?

  • Patch Set #1, Line 11: PCI_DEV(0, VTD_DEV, VTD_FUNC)

    Maybe #define this?

  • Patch Set #1, Line 16: tseg_base &= 0xfff00000;

    I'd use:

     tseg_base = ALIGN_DOWN(tseg_base, 1 * MiB);

  • Patch Set #1, Line 19: this effectively means

    nit: Move this part to the next line, so that the comment is more rectangular

To view, visit change 46657. To unsubscribe, or for help writing mail filters, visit settings.