Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49058 )
Change subject: mb/google/hatch (baseboard): add ACPI backlight support
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@10
PS1, Line 10: PUFF-based variants do not have an attached display
I'm going to ask some Google people if I can split HATCH and PUFF, for sanity's sake […]
Commit message updated, splitting hatch from puff is a separate issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ce4c6e1c78299e89760a1356da452d56ba0aee6
Gerrit-Change-Number: 49058
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Jan 2021 18:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment