1 comment:
Patch Set #4, Line 88: if (!CONFIG(TSEG_STAGE_CACHE) && !CONFIG(CBMEM_STAGE_CACHE))
Either I am doing it wrong, or we are hitting Kconfig restriction. It's not a three-way choice and NO_STAGE_CACHE would be better named DISABLE_STAGE_CACHE.
In other words, we NO_STAGE_CACHE will not be set in the case user, by menu option, leaves CBMEM_STAGE_CACHE not enabled.
So I understand correctly: You are trying to handle the following case?NO_STAGE_CACHE=n
TSEG_STAGE_CACHE=n
CBMEM_STAGE_CACHE=nIf so, can we update the Kconfig options to handle that scenario? Below is what we have.
We could stop exposing it to the user or make it a choice selection like you noted? It seems somewhat orthogonal to removing RESET_ON_INVALID_RAMSTAGE_CACHE on its own. It seems we're putting two different changes together.
It is not entirely orthogonal. If we essentially set RESET_ON_INVALID_RAMSTAGE_CACHE=y as we remove the symbol, boards with NO_STAGE_CACHE=n will start to hit board_reset() below for the resume path.
I'll try to make it a three-way choice and move it to be submitted first.
To view, visit change 37682. To unsubscribe, or for help writing mail filters, visit settings.