Patch Set 6:

Patch Set 5:

Since so much of this leverages soc/intel/cannonlake and the existing sarien/arcada devices does it make sense to have this be another variant of mb/google/sarien?

Drallion EV uses sarien/arcada boards with cometlake SOC. But from Drallion EVT, the boards are different in memory, Audio codec, WIFI modules and if we add it as a variant now, we might have to move the code again in the EVT phase. Also, since the SOC is different it would be good if we don't add it as a Sarien Variant. Please advice!

I discussed this with Duncan and we are going to keep drallion as its own mainboard and not a sarien variant.

Patch set 6:Code-Review +1

View Change

To view, visit change 34497. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 6
Gerrit-Owner: Thejaswani Putta <thejaswani.putta@intel.com>
Gerrit-Reviewer: AndreX Andraos <andrex.andraos@intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mathew King <mathewk@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Thejaswani Putta <thejaswani.putta@intel.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:08:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment