5 comments:
Patch Set #5, Line 69: _car_ehci_dbg_info_end = .;
We're also moving the location of ehci info in this patch to be outside of relocatable window. Do it in another patch?
Patch Set #5, Line 55: static struct timestamp_cache timestamp_cache;
Given that TIMESTAMP_CACHE_IN_BSS is 0 why isn't that as well as this object removed?
Patch Set #5, Line 168: timestamp_add_table_entry(timestamp_table_get(), id, ts_time);
Below you check the return value of timestamp_table_get() for NULL but you don't here. Why?
Patch Set #5, Line 246: static void timestamp_sync_cache_to_cbmem(int is_recovery)
Why did this function move? Can we put it back to its original location for easier reviewing?
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
Patch Set #5, Line 108: timestamp_init(get_initial_timestamp());
Put these changes in another patch? Also add some comments as to why this should be placed here.
To view, visit change 35032. To unsubscribe, or for help writing mail filters, visit settings.