Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 9: #3461454
can you make this a link, e.g. […]
Wait a minute. CONFIG_LP_VBOOT_LIB=y should be set by default. It defaults to 'y' for ChromeOS builds. And depthcharge should always be built with CONFIG_LP_CHROMEOS=y. I do not see a reason to enable it in libpayload defconfig. If one wants it, they should enable it on purpose, because it is not necessary.
To view, visit change 63240. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2bb2ce42a314e05ef22ea7b8abc067d6361d511
Gerrit-Change-Number: 63240
Gerrit-PatchSet: 3
Gerrit-Owner: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Zhixing Ma <zhixing.ma@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Tue, 05 Apr 2022 15:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment