Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 1:
(2 comments)
Thanks for following up on this Brandon!
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/ear... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/ear... PS1, Line 286: system_requires_early_display You can replace this with if (!display_init_required()). It does exactly what system_requires_early_display() is doing but using vboot flags that requests display init.
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/1/src/soc/intel/tigerlake/inc... PS1, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data); Drop this instead of commenting.