Patch Set 6: Code-Review+2

Patch Set 6: Code-Review+1

(1 comment)

Hey folks, does anyone have an opinion on this? I'd prefer to
get it in, simply because it avoids complexity. I don't think,
but can't prove, that it's really harmless to have both the
emulation and the actual timer available.

Sorry about the delay in response. I digged through my notes as well as the specs I have access to, but I don't see any reason why we cannot have multiple timers available. I believe the confusion was around the comment in some of the specs that emulated timer needs to be enabled when the ACPI PM hardware timer is disabled which is required for power savings. But, it does not apply the other way around i.e. having emulated timer enabled does not require the ACPI PM hardware timer to be disabled.

Thanks for checking this. That's how I understood it, too

View Change

To view, visit change 45000. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0d7fa6f9766c7c4e2fa9e846c179adc6a4e1681
Gerrit-Change-Number: 45000
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:43:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment