6 comments:
File Documentation/soc/amd/family15h.md:
Patch Set #4, Line 5: _Excavator_
This is a misleading statement. Family 15h contains way more microarchitectures than just Excavator.
models **60h-6Fh** (_Merlin Falcon_) and
**70h-7Fh** (_Stoney Ridge_).
Why bold?
I concur with Martin. Since you're making this a Family 15h document, please don't make it specific to only Models 60h-6Fh and 70h-7Fh. Definitely don't word it to exclude the others. BTW coreboot also contains Family 15h 00h-0Fh support in native source. You can download a 2 year old slide deck for AMD at https://www.coreboot.org/Denver2017.
This documentation assumes
familiarity with x86, its reset state and its early initialization
requirements.
I'm not sure the Family 17h warning about x86 reset adds anything to Family 15h. Family 17h is different than everything else, and the reset process was described in that other file.
Don't use (R) after the first instance in any document. For AMD, don't use it at all.
Patch Set #4, Line 23: (_AGESA ™_). _AGESA_ c
Why are these italicized?
By the way, this use of TM on the first AGESA but not the second is correct.
Patch Set #4, Line 44: https://www.amd.com/system/files/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf
We're discussing whether we can mirror the documents on a coreboot server, but until then, maybe poi […]
Are you worried about the URL changing? While potentially a risk, it looks like they've named it without a revision so they can keep some stability even when updating the docs. To me it seems more useful to point to the latest for as long as it exists.
To view, visit change 34561. To unsubscribe, or for help writing mail filters, visit settings.