Patch Set 2:

This is untested and no objective was given why one of _ADR or _HID was preferred over the other. It's unclear if there are OS that requires one of them to be present.

SerialIO devices are always in ACPI mode for these platforms on all boards in the tree, and _HID is required for ACPI mode, so makes sense to drop _ADR here

Yes this is correct these were always just put in ACPI mode on baytrail. This is something where Intel went back and forth on and eventually settled PCI mode in future chipsets.

I tried to support both modes in coreboot (which is why it had both _HID and _ADR) but it may be easier to settle on one path, or put this behind a Kconfig variable.

View Change

To view, visit change 37935. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949393558f5af66689c167b2e593a1461f641962
Gerrit-Change-Number: 37935
Gerrit-PatchSet: 3
Gerrit-Owner: Jonas Moehle <ad-min@mailbox.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Jonas Moehle <ad-min@mailbox.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 19:54:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment