[coreboot-gerrit] [S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config

[Subrata Banik (Code Review)]

Attention is currently required from: Tim Van Patten.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email )

Change subject: vendorcode/google/chromeos: API to read factory config
......................................................................

Patch Set 3:

(2 comments)

File src/vendorcode/google/chromeos/ti50_misc_cmd.c:

https://review.coreboot.org/c/coreboot/+/79737/comment/a6b59805_77b07c9a :
PS1, Line 20: 	if (rc == TPM_CB_NO_SUCH_COMMAND) {
> `TPM_CB_NO_SUCH_COMMAND` is not the only value `tlcl_ti50_get_factory_config()` can return, so the o […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/79737/comment/5da17b4f_7dcf7334 :
PS1, Line 26: 	return factory_config;
> `factory_config` is a `uint64_t`, while this function returns a `uint8_t`. […]

Acknowledged