9 comments:
File src/mainboard/medion/ms_7707/acpi_tables.c:
Patch Set #1, Line 31: gnvs->lids = 1;
there's no lid
File src/mainboard/medion/ms_7707/devicetree.cb:
Patch Set #1, Line 38: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
can be removed as the default is all zero
Patch Set #1, Line 41: register "sata_port_map" = "0xc"
two sata ports are missing
Patch Set #1, Line 109: io 0x60 = 0x295
are you sure? usually they are aligned to 2.
File src/mainboard/medion/ms_7707/dsdt.asl:
Patch Set #1, Line 38: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
no need for brightness as there's no GMA
File src/mainboard/medion/ms_7707/mainboard.c:
Patch Set #1, Line 23: /* install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
no dead code please
File src/mainboard/medion/ms_7707/romstage.c:
Patch Set #1, Line 29: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x84, 0x00fc0295);
do you need to access that IO range in romstage? if not it can be moved to devicetree.
Patch Set #1, Line 30: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x88, 0x00000000);
Ranges set to zero can be removed, as it's the power on reset
configure superio for serial output here
To view, visit change 32235. To unsubscribe, or for help writing mail filters, visit settings.