Attention is currently required from: Tim Wawrzynczak.
View Change
1 comment:
File src/acpi/acpi.c:
Patch Set #17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
I'm fine with this approach, but a Kconfig would also work.
@Tim from your end, do you have any strong preference one way or the other?
To view, visit change 63969. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 17
Gerrit-Owner: Tarun Tuli <taruntuli@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Tue, 03 May 2022 17:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli@google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment