[coreboot-gerrit] [L] Change in coreboot[master]: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload

[Patrick Rudolph (Code Review)]

Attention is currently required from: Michał Żygowski, Martin L Roth, Benjamin Doron.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378 )

Change subject: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload
......................................................................

Patch Set 8:

(2 comments)

File src/drivers/s3_save_restore/cbtable.c:

https://review.coreboot.org/c/coreboot/+/70378/comment/4dd1d691_e3a54abb 
PS8, Line 52: void lb_save_restore(struct lb_header *header)
Everything in here is platform specific and could be
1) be part of Edk2Platforms and hardcode those values
2) be part of UefiPayloadPkg and detect those values by matching MCH/PCH IDs.

https://review.coreboot.org/c/coreboot/+/70378/comment/89c26e0a_c5663a47 
PS8, Line 172: LB_TAG_PLD_NV_VARIABLE_INFO
there's no need for such table:
- The payload is coreboot aware
- The payload has a platform specific SPI driver

Thus the payload can find and parse the FMAP by itself.