5 comments:
File util/amdfwtool/amdfwtool.c:
Patch Set #67, Line 1478: if (list_deps) {
braces {} are not necessary for single statement blocks
File util/amdfwtool/data_parse.c:
Patch Set #67, Line 401: fprintf(stderr, "Module's name \"%s\" is not valid\n", oneline);
line over 96 characters
Patch Set #67, Line 403: } else {
else is not generally useful after a break or return
Patch Set #67, Line 404: if (print_deps)
Too many leading tabs - consider code refactoring
Patch Set #67, Line 413: fprintf(stderr, "AMDFWTOOL config file line can't be parsed \"%s\"\n", oneline);
line over 96 characters
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.