Felix Held has uploaded this change for review.

View Change

soc/amd/picasso: move UART console code to common folder

Change-Id: Ibc9a4c05bdfc7cd3cd0eada67563386c95d2b50e
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
---
A src/soc/amd/common/block/uart/Makefile.inc
R src/soc/amd/common/block/uart/uart_console.c
M src/soc/amd/picasso/Makefile.inc
3 files changed, 15 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48515/1
diff --git a/src/soc/amd/common/block/uart/Makefile.inc b/src/soc/amd/common/block/uart/Makefile.inc
new file mode 100644
index 0000000..9d96845
--- /dev/null
+++ b/src/soc/amd/common/block/uart/Makefile.inc
@@ -0,0 +1,15 @@
+ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_UART),y)
+
+bootblock-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
+
+romstage-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
+
+verstage_x86-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
+
+ramstage-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
+
+ifeq ($(CONFIG_DEBUG_SMI),y)
+smm-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
+endif
+
+endif # CONFIG_SOC_AMD_COMMON_BLOCK_UART
diff --git a/src/soc/amd/picasso/uart_console.c b/src/soc/amd/common/block/uart/uart_console.c
similarity index 100%
rename from src/soc/amd/picasso/uart_console.c
rename to src/soc/amd/common/block/uart/uart_console.c
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index 783517d..3e04ecc 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -16,7 +16,6 @@
bootblock-y += early_fch.c
bootblock-y += i2c.c
bootblock-y += uart.c
-bootblock-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
bootblock-y += gpio.c
bootblock-y += reset.c

@@ -26,14 +25,12 @@
romstage-y += reset.c
romstage-y += memmap.c
romstage-y += uart.c
-romstage-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
romstage-y += psp.c
romstage-y += mrc_cache.c

verstage-y += i2c.c
verstage_x86-y += gpio.c
verstage_x86-y += uart.c
-verstage_x86-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
verstage_x86-y += reset.c

ramstage-y += i2c.c
@@ -52,7 +49,6 @@
ramstage-y += memmap.c
ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
ramstage-y += uart.c
-ramstage-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
ramstage-y += finalize.c
ramstage-y += soc_util.c
ramstage-y += psp.c
@@ -66,7 +62,6 @@
smm-y += smihandler.c
ifeq ($(CONFIG_DEBUG_SMI),y)
smm-y += uart.c
-smm-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
endif
smm-y += gpio.c
smm-y += psp.c

To view, visit change 48515. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9a4c05bdfc7cd3cd0eada67563386c95d2b50e
Gerrit-Change-Number: 48515
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: newchange