Attention is currently required from: Paul Menzel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84903?usp=email )
Change subject: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/pantherlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/84903/comment/3f0b3a00_b40c57ca?usp... :
PS1, Line 28: static void save_dimm_info(void)
This looks very similar to other Intel SOC implementations. Isn’t this only dependent on the FSP version, and could be unified?
yes, I will consider moving this into some common location inside FSP.
marking it resolved till then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84903?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b942610272de401589ee0463de9cd0985974774
Gerrit-Change-Number: 84903
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 29 Oct 2024 13:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org