Patch Set 3:

Patch Set 1:

I think we would want to push these strings to devicetree.cb.

Devicetree does not seem appropriate as this is an SOC level binding and not something the mainboard should tweak. These names need to match what is in any static ASL.

Static ASL already has to match strings in soc/*.c.
https://review.coreboot.org/c/coreboot/+/35734/2/src/soc/intel/fsp_broadwell_de/southcluster.c

I agree these identifiers should not be defined in mb/x/devicetree.cb, but we may be introducing soc/x/devicetree.cb files to define alias names for PCI functions.

View Change

To view, visit change 35736. To unsubscribe, or for help writing mail filters, visit settings.