Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Angel Pons, Michael Niewöhner.
10 comments:
Commit Message:
PCIE ClkSrcUsage and ClkSrcClkReq are always confusing in devicetree.
Make it easier to just fill the number from schematics.
Will change in the final commit. We still have problem with CPU RP ports need to work out.
Done
File src/soc/intel/alderlake/chip.h:
tic inline int pcie_is_flag_enabled(const struct pcie_rp_config pcie_rp,
enum pcie_rp_flags flag_mask)
{
return pcie_rp.flags & flag_mask ? 1 : 0;
}
Yes, will clean up with move pcie_rp_config to pcie_rp.
Done
File src/soc/intel/alderlake/fsp_params.c:
Patch Set #34, Line 264: config->pch_pcie_rp[i]
To save some redundancy, I would use a pointer as follows: […]
let me think. looks fine.
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #23, Line 154: is_dev_enabled(dev)
okay, I think Subrata not answer my question,yet. But I can follow it for review.
Done
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #28, Line 43: CpuPcieRpEnableMask
only one rp?
Done
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #32, Line 20: enum pcie_rp_type {
TODO: move to pcie_rp. […]
only this file use this. no need.
File src/soc/intel/alderlake/romstage/fsp_params.c:
nit: pass pointers instead? It should be more efficient than passing by copy
Done
PCIE_CLK_FREE
Done
return m_cfg->PcieRpEnableMask & BIT(rp_number);
if (type == CPU_PCIE_RP)
return m_cfg->CpuPcieRpEnableMask;
I think this is work use PcieRpEnableMask/CpuPcieRpEnableMask as parameter and remove the type :) Wi […]
Done
Patch Set #34, Line 44: CpuPcieRpEnableMask
Still wait Furquan patch the helper... And I think I need to add new KConfig for CPU_RP count first.
Done
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.