Karthik Ramasubramanian submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Edward Doan: Looks good to me, but someone else must approve
mb/google/dedede/var/bugzzy: Update GPP_D5 configuration

As we checked the panel doesn't display firmware screen if we hold
GPP_D5(TOUCHSCREEN_RESET) low on bugzzy. It's because of that bugzzy
uses the built-in touch screen on the panel, the panel seems like
under reset state by the TOUCHSCREEN_RESET signal.
This change sets default GPP_D5 level to high for bugzzy.

BUG=b:None
BRANCH=dedede
TEST=built and verified bugzzy showed firmware screen

Signed-off-by: Seunghwan Kim <sh_.kim@samsung.corp-partner.google.com>
Change-Id: I53e4fc52ceb14ba23c22d3c105f65634b09029f1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58073
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward Doan <edoan@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
---
M src/mainboard/google/dedede/variants/bugzzy/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/dedede/variants/bugzzy/gpio.c b/src/mainboard/google/dedede/variants/bugzzy/gpio.c
index ce88b5e..d089162 100644
--- a/src/mainboard/google/dedede/variants/bugzzy/gpio.c
+++ b/src/mainboard/google/dedede/variants/bugzzy/gpio.c
@@ -21,6 +21,8 @@
PAD_NC(GPP_D1, NONE),
/* D3 : WLAN_PCIE_WAKE_ODL ==> NC */
PAD_NC(GPP_D3, NONE),
+ /* D5 : TOUCHSCREEN_RESET */
+ PAD_CFG_GPO(GPP_D5, 1, DEEP),
/* D7 : EMR_INT_ODL */
PAD_CFG_GPI_APIC(GPP_D7, NONE, PLTRST, LEVEL, INVERT),
/* D13 : EN_PP3300_CAMERA */

To view, visit change 58073. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53e4fc52ceb14ba23c22d3c105f65634b09029f1
Gerrit-Change-Number: 58073
Gerrit-PatchSet: 2
Gerrit-Owner: shkim <sh_.kim@samsung.com>
Gerrit-Reviewer: Edward Doan <edoan@google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: SH Kim <sh_.kim@samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged