Patch Set 3:

Is this for mainboards that have both integrated and discrete
graphics onboard? or only discrete graphics?

Very nice question Nico, i was about to come to this disucssion.
We are looking for two mainboard design

1. only discrete GFX over PCIE (no IGD)=> This i'm could able to achieve easily using MAINBOARD_HAS_DGPU_VGA_INIT and MAINBOARD_NO_FSP_GOP Kconfig select from mainboard.

2. Both onboard (IGD) and discrete GFX (DGPU) and based on some switch change the display dynamically => This is problem at present as RUN_FSP_GOP and VGA_ROM_RUN both are part of choice option hence couldn't able to select both from mainboard. Ideally for this type of mainboard design, we need to have both RUN_FSP_GOP and VGA_ROM_RUN enable in Kconfig and coreboot decide based on switch position if like to call FSP for IGD display or load/execute VGA OpROM for DGPU init. Right now, i'm commenting choice option in my local repo and selecting both Kconfig to make this dynamic display possible.

View Change

To view, visit change 49016. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb2fcdb105af449bc20ad727759cdef17d5e376
Gerrit-Change-Number: 49016
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Thu, 31 Dec 2020 05:00:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment