Attention is currently required from: Arthur Heymans, Ashish Kumar Mishra, Paul Menzel, Saurabh Mishra, Subrata Banik.
2 comments:
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
Patch Set #4, Line 81: (len >> 2)
This optimisation can be done by the compiler. There's absolutely no reason to write code that's harder for people to understand. Just use `len / 4`, please. The point is to use `4` everywhere (or, if you want, `sizeof(uint32_t)`.
Patch Set #4, Line 85: (len & 3)
Same here, please use `len % 4`
To view, visit change 82079. To unsubscribe, or for help writing mail filters, visit settings.