Subrata Banik submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Raymond Chung: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved
mb/google/brya/var/xol: Using baseboard's PchPmSlpAMinAssert settings

Reduce PchPmSlpAMinAssert (pch_slp_a_min_assertion_width) to minimum
time (98ms) from 2sec.

BUG=b:349595391
BRANCH=firmware-brya-14505.B
Test=Verified on xol

Change-Id: Ia4b7b7ab5dc9afeb3505dfd2b42d0d397aed7a5c
Signed-off-by: Raymond Chung <raymondchung@ami.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83683
Reviewed-by: Eric Lai <ericllai@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
---
M src/mainboard/google/brya/variants/xol/overridetree.cb
1 file changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/brya/variants/xol/overridetree.cb b/src/mainboard/google/brya/variants/xol/overridetree.cb
index 5de8c73..529cb37 100644
--- a/src/mainboard/google/brya/variants/xol/overridetree.cb
+++ b/src/mainboard/google/brya/variants/xol/overridetree.cb
@@ -23,8 +23,6 @@

register "sagv" = "SaGv_Enabled"

- register "pch_slp_a_min_assertion_width" = "SLP_A_ASSERTION_DEFAULT"
-
# As per Intel Advisory doc#723158, the change is required to prevent possible
# display flickering issue.
register "disable_dynamic_tccold_handshake" = "true"

To view, visit change 83683. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4b7b7ab5dc9afeb3505dfd2b42d0d397aed7a5c
Gerrit-Change-Number: 83683
Gerrit-PatchSet: 2
Gerrit-Owner: Raymond Chung <raymondchung@ami.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Raymond Chung <raymondchung@ami.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Eddy Lu <eddylu@ami.corp-partner.google.com>
Gerrit-CC: Edward Doan <edoan@google.com>
Gerrit-CC: SH Kim <sh_.kim@samsung.corp-partner.google.com>
Gerrit-CC: YH Lin <yueherngl@google.com>