3 comments:
is that a typo or is that a name from some spec?
from VPD 2.0 spec
Patch Set #1, Line 308: static
why static?
good question. I just cribbed this from google/sarien
har *smbios_system_serial_number(void)
{
static char serial[VPD_SERIAL_LEN];
if (vpd_gets(VPD_KEY_SYSTEM_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
return serial;
return "";
}
const char *smbios_mainboard_serial_number(void)
{
static char serial[VPD_SERIAL_LEN];
if (vpd_gets(VPD_KEY_MAINBOARD_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
return serial;
return "";
}
#endif
shouldn't that go to smbios and make use of vpd functionality from there? (also the Kconfig)
IDK, should it? seems like these methods are located in the overriding entity, so would make sense to have them in vpd driver
To view, visit change 49050. To unsubscribe, or for help writing mail filters, visit settings.