Patch Set 10: Code-Review+1
(3 comments)
Can you autodetect the EC version at runtime? Some have revision registers in the EC space.
I don't know such registers and I don't have old MacBook 2,2 at the moment.
14 comments:
Yeah... I have copies on all macbooks and they are not very good synchronized with each other. […]
Done
Patch Set #16, Line 10: its duplication in mainboards
nit: add two spaces at the beginning of the line to align the text
Done
File src/ec/apple/acpi/ac_01.asl:
Still unresolved
Done
Patch Set #10, Line 34: return(HPAC)
Still unresolved
Done
File src/ec/apple/acpi/ac_60.asl:
Patch Set #10, Line 34: return(HPAC)
Still unresolved
Done
File src/ec/apple/acpi/ac_60.asl:
Is this the bit where LIDS resides?
Yes
File src/ec/apple/acpi/ec.asl:
Still unresolved
It stops working with FixedIO. Linux throws multiple EmbeddedController ACPI-related errors, something with AE_TIME and boot takes 5 min instead of 5 sec.
Patch Set #10, Line 50: return (Package () { 0x23, 0x04 })
Still unresolved
Done
File src/ec/apple/acpi/lid_01.asl:
Patch Set #10, Line 34: return(LIDS)
Still unresolved
Done
Patch Set #10, Line 39: Return (Package() { 0x1d, 0x03 })
Still unresolved
Done
File src/ec/apple/acpi/lid_01.asl:
The first difference
Done
The first difference
Done
Patch Set #16, Line 39: { 0x1d, 0x03 }
The second difference
Done
Patch Set #16, Line 39: { 0x1d, 0x03 }
The second difference
Done
To view, visit change 33102. To unsubscribe, or for help writing mail filters, visit settings.